-
-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Interface manual basics #9632
base: master
Are you sure you want to change the base?
Interface manual basics #9632
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some initial feedback, needs some extensive work for grammar and wording and will go over again when I find the time
e278a05
to
d318036
Compare
39dc595
to
90af831
Compare
cc8c1c4
to
7f886a2
Compare
I think #10282 covers the project settings window reasonably well |
Can this be broken up into multiple PRs for the different pages for easier review? Some of the pages here look ready for review, if they were split into individual PRs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know this is still a draft, but here's a bit of feedback that stood out to me while reading it.
After making changes, open the `Editor` menu at the top of the editor then | ||
choose `Editor Layouts > Save`. Enter a name for the layout, then click | ||
`Save`. If you've already saved an editor layout, you can choose to override |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All these should not be changed. The docs generally use Bold for interactible UI buttons, not italics. The docs are currently inconsistent about this, but in #10169 we put this into a formal guideline.
Import Dock | ||
=========== | ||
|
||
Import dock allows you to change the importing parameters of non-native resources |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Import dock allows you to change the importing parameters of non-native resources | |
The Import dock allows you to change the importing parameters of non-native resources |
IMO all these pages should start with "The Import dock" or "The Inspector dock" rather than "Import dock" or "Inspector dock".
If the inspector dock is visible, clicking on a node in the scene tree will automatically | ||
display its properties. | ||
If it is not visible, you can show it by navigating to | ||
`Editor > Editor Settings > Editor Docks > Inspector`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
`Editor > Editor Settings > Editor Docks > Inspector`. | |
**Editor > Editor Settings > Editor Docks > Inspector**. |
As mentioned earlier, generally bold for UI buttons and menu paths like these.
Node Dock | ||
========= | ||
|
||
Node dock has two tabs: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Node dock has two tabs: | |
The Node dock has two tabs: |
Signals | ||
------- | ||
|
||
The `Signals` tab lists the signals of the selected node in the Scene dock which the node can emit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The `Signals` tab lists the signals of the selected node in the Scene dock which the node can emit. | |
The **Signals** tab lists the signals of the selected node in the Scene dock which the node can emit. |
@@ -1,7 +1,7 @@ | |||
.. _doc_project_manager: | |||
|
|||
Using the Project Manager | |||
========================= | |||
Project Manager |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this change! IMO sometimes the docs needlessly uses "Using X" rather than just "X" for titles just to follow a guideline.
@@ -5,12 +5,21 @@ | |||
Project Settings | |||
================ | |||
|
|||
This page explains how to use the Project Settings window. If you would like to access and modify project settings via code, see :ref:`ProjectSettings <class_ProjectSettings>`. | |||
.. warning:: This page is a work-in-progress. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should not have notes of this form. We should bring the page to a correct state, even if it is very short, and not directly comment on future changes within the text of a page.
@@ -0,0 +1,25 @@ | |||
.. _doc_workspace_selector: | |||
|
|||
Workspace selector |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's check if this has an official name in the editor itself, or if it was named a "workspace selector" either in this PR or in a prior docs PR.
I think the name is a good one, but by adding a page here we're solidifying the name as the official one.
in the project. | ||
- **AssetLib** allows you to download plugins and addons for your project. This requires Godot to | ||
be in online mode. Unlike the Asset Library in the project manager, the results will not include | ||
complete game demos. See :ref:`AssetLib <toc-learn-features-assetlib>` for more details. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This link should probably be to an anchor, not a toc. You might need to add an anchor above the toc.
I will go over your comments and try to separate them! Thanks! |
This is an initiative to have a detailed manual on editor's interface elements. Which menu does what, where to find a specific tool, etc.
Currently, some useful functionality is discovered by accident. By looking at the merged PRs of such items (e.g., menu items or toolbar buttons) as well as the source code, I am trying to document the usage of each interface element in different sections.
Currently on this page we on this page: https://docs.godotengine.org/en/stable/tutorials/editor/index.html, we have:
No usage of the menus, toolbars etc. I have currently the following items, still WIP:
Editor's Interface:
Interface Elements:
Main menus
Workspace selector
Playtest buttons and renderer
Scene switcher
Bottom panel
Default panels, from scratch, or reference to existing pages
Docks:
Scene Dock (separate commit)
Import
FileSystem
Inspector
Node
History
Each dock on its own page, either new page, or reference to existing pages.
Customization:
I think it makes sense to have an overview of all interfaces, elements including (basic) usage.
PS: There are also tools to be documented, such as Orphan Resource Explorer, Docks themselves, or some optimization topics such as Customize run instance, but I think this should be the starting point.